Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2SP] Remove custom BlockRegistry from opendigitizer , use standard one from gr4 #256

Open
drslebedev opened this issue Jan 17, 2025 · 1 comment
Assignees

Comments

@drslebedev
Copy link
Contributor

opendigitizer includes a custom implementation of the block registry that replicates the functionality of BlockRegistry from gr4.

This custom implementation should be removed, and the gr4 implementation should be used exclusively.

@github-project-automation github-project-automation bot moved this to 🆕 Ideas (∞) in Digitizer Reimplementation Jan 17, 2025
@drslebedev drslebedev moved this from 🆕 Ideas (∞) to 🔖 Selected (6) in Digitizer Reimplementation Jan 17, 2025
@frankosterfeld
Copy link
Contributor

frankosterfeld commented Feb 5, 2025

I think especially for handling of remote flowgraphs it would be useful to have a block type "meta" description (describing available block types, their properties, ports, etc.) that's not tied to locally available GR4 blocks. For that I'd find it desirable to have a separate data structure that doesn't require that the described block can be instantiated locally.
For remote graphs, the worker would send these descriptions to the UI, which the UI would then use in the remote graph editor.

One could consider to move the "meta type" structure up to GR4, and extend GR4's BlockRegistry provide these meta types. Right now it's focused around creating instances, instead of describing their properties without instantiating them.

@ivan-cukic ivan-cukic changed the title Remove custom BlockRegistry from opendigitizer , use standard one from gr4 [2SP] Remove custom BlockRegistry from opendigitizer , use standard one from gr4 Feb 17, 2025
@ivan-cukic ivan-cukic moved this from 🔖 Selected (6) to 🏗 In progress in Digitizer Reimplementation Feb 17, 2025
@ivan-cukic ivan-cukic self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants