-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork using Vanara libs supporting lots of .NET versions #41
Comments
Hey David; happy to see you here; been using your Thanks for the port. However, forgive me for not seeing how these changes actually solve any issue or bring something new to the table. This library is on NetStandard 2 now and therefore is useable by NetCore and other libraries targeting NetStandard. .Net2 support is interesting, especially since this library should in theory support Windows XP, however, I was thinking of removing this feature and all links to the legacy API anyway. All this along with the fact that this change unnecessary adds two new dependencies to the project ( Did you try it on NetCore2? Since Can |
You're right, nothing much new here. In fact, I started the port mostly so that I wouldn't have to write a ton of unit tests for my FirewallApi COM extraction. I have got this working on earlier .NET Core versions. You can find the implementation of You may also want to look at some of my optimizations in your helper classes. There were quite a few cases where a lot of code could be wrapped into a single Linq call.
Vanara does have multi-version support for the
I tried doing this for |
Can you make this work on remote machines also? Or just local? I have searched and cannot figure out how to use on remote. |
Allow me to keep this issue open so I can take another deeper look into the changes and the
Please consider opening a new issue about this. As far as I know, managing remote machines' firewall rules is possible through WMI and this library was only a COM wrapper since now. Adding this feature requires a lot of abstraction and obviously new pieces of code to works well. I will keep the new issue open as a feature request. |
Moving to new issue |
Not really an issue, just an offer. I have forked the code and changed out the underlying COM classes for those in Vanara.PInvoke.FirewallApi. This lib supports .NET 2-4.x, .NET Core 2.0-3.1, and .NET Std 2.0. I then added those same supported options to the
WindowsFirewallHelper
assembly. If you're interested, I'm happy to help add in and support in your master.The text was updated successfully, but these errors were encountered: