Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--binaries should automatically add .exe on Windows #27

Open
jhasse opened this issue Oct 31, 2016 · 2 comments
Open

--binaries should automatically add .exe on Windows #27

jhasse opened this issue Oct 31, 2016 · 2 comments

Comments

@jhasse
Copy link

jhasse commented Oct 31, 2016

Using fish on Windows via MSYS2 the automatic suggestion to install the correct package only works when typing the full binary name, including .exe, see fish-shell/fish-shell#3428.

As it calling binaries on Windows works with and without the .exe extension, it would be great if pkgfile handled this automatically.

@falconindy
Copy link
Owner

Is there a preprocessor macro I can use to detect compilation on windows? I don't think this should be done for unixy installs.

@jhasse
Copy link
Author

jhasse commented Oct 31, 2016

Yes, _WIN32 is only definied on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants