Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username not updating to reflect jellyfin name #1319

Closed
1 task done
szethh opened this issue Jan 31, 2025 · 5 comments
Closed
1 task done

Username not updating to reflect jellyfin name #1319

szethh opened this issue Jan 31, 2025 · 5 comments

Comments

@szethh
Copy link

szethh commented Jan 31, 2025

Description

Hi, so I have a user that was first created in jellyfin, and then set up in jellyseerr as well.

The name had a typo so I changed it in jellyfin, but the old name remains in jellyseerr. I know I can change the display name from jellyseerrs's users page, but I was wondering if this could happen automatically? As in, could the name be pulled from jellyfin?

The user can still log in fine to jellyseerr, but they write "User A" in the login field, and they get greeted with "Hello User B" when logged in.

I can also delete and re-add the user but that would remove all the request data associated with said user.

Version

2.1.0

Steps to Reproduce

  1. Create jellyfin user "User A"
  2. Log in to jellyseerr with said user
  3. Change name via jellyfin to "User B"
  4. Jellyseerr still shows "User A", even across restarts. Reimporting from the users page does not resolve the issue.

Screenshots

No response

Logs

Platform

desktop

Database

SQLite (default)

Device

Any

Operating System

Any

Browser

Any

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@szethh szethh added awaiting triage This issue needs to be reviewed bug Something isn't working labels Jan 31, 2025
@fallenbagel
Copy link
Owner

fallenbagel commented Jan 31, 2025

Are you logging in using the jellyfin login form. Because if you do, the username would update. (Not local login)

https://github.com/fallenbagel/jellyseerr/blob/develop/server%2Froutes%2Fauth.ts#L421

As in the user HAS to relogin using the jellyfin login form to update their username. Otherwise it won't update.

@fallenbagel
Copy link
Owner

fallenbagel commented Jan 31, 2025

Screenshot_20250201_001144_Firefox Beta.jpg

I can confirm it works. I created a user called Testuser12. Logged in as them. Then changed the name to Testuser1 in jellyfin. Then logged out and back in as Testuser1 using the JELLYFIN login form. And see the name changed. The () name is the local user name which correlates to their email. Since jellyfin users do not have an email, when they login, their email becomes their username (which is whats used for local login). This updates when you update the email as seen below:

Screenshot_20250201_000923_Firefox Beta.jpg

But as you can see the users name updated properly when logged in using the jellyfin login form.

@fallenbagel fallenbagel removed bug Something isn't working awaiting triage This issue needs to be reviewed labels Jan 31, 2025
@szethh
Copy link
Author

szethh commented Jan 31, 2025

i'm not sure i follow. the original username is Testuser12. You then change it to Testuser1, log out and back in using the jellyfin form on jellyseerr, and the display name updates but not the name in parenthesis. as shown in your screenshot, it remains testuser12.

that is what i meant, the username shown in the brackets is not changing for me

@szethh
Copy link
Author

szethh commented Jan 31, 2025

for anyone coming across this in the future, I managed to change the username it by going to edit the user, then click save changes without modifying/filling in any field. not sure how exactly but that fixed it, and now the name in between brackets is gone :)

@fallenbagel
Copy link
Owner

fallenbagel commented Jan 31, 2025

i'm not sure i follow. the original username is Testuser12. You then change it to Testuser1, log out and back in using the jellyfin form on jellyseerr, and the display name updates but not the name in parenthesis. as shown in your screenshot, it remains testuser12.

that is what i meant, the username shown in the brackets is not changing for me

I don't think you understand. As you can see from screenshot 1 it was changing the jellyfinUsername. That is NOT EQUAL to display name. The display name IS NOT CHANGED. You can clearly see that it did not change by seeing the field EMPTY.

Display name changes along with the Jellyfin username. To reflect it.

I think i know where your confusion is coming from but when you change your name and logged in, it's not changing the display name only. It's changing the jellyfinUsername.

What you see in the bracket is the email. Email is NOT your username.

When the user initially joins, the jellyfinUsername IS ASSIGNED to the email field. This is because jellyfin does not have an email. So when the user changed the jellyfin username IT CHANGED the username properly when they logged in. The () value is email. And is whats used for jellyseerr login. Which should not be changed through db editing and rather using the field we expose for you, I.e the email field.

Which ofcourse would be used for subsequent jellyseerr local logins.

Screenshot_20250201_010339_Chrome Dev.jpg

As you can see from my screenshot, the display name is NOT set. Email IS set. I can still change my display name to whatever. But that () IS NOT your username. It IS your email. Used in jellyseerr local logins and smtp and jellyseerr local account reset passwords.

And this is after display name is set:

Screenshot_20250201_010733_Chrome Dev.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants