Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit fstrm_capture --max-conns concurrent connections #55

Open
reedjc opened this issue May 10, 2018 · 0 comments
Open

Revisit fstrm_capture --max-conns concurrent connections #55

reedjc opened this issue May 10, 2018 · 0 comments

Comments

@reedjc
Copy link
Contributor

reedjc commented May 10, 2018

Document what numbers are allowed for --maxconns for fstrm_capture.

Check for valid max-conns value. (Because libmy/argv.c using atoi(3) has many caveats and doesn't do checking).

It defaults to -1 and each cb_accept_conn will decrement (like == -2) and cb_close_conn will increase (like == 0). I am unclear if this behavior is correct. And I didn't test it. cmikk asked me to open this ticket to revisit its behavior, such as if the 0 is used.

@reedjc reedjc changed the title Revisit --max-conns concurrent connections Revisit fstrm_capture --max-conns concurrent connections May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant