Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure msrv 1.80.1 and upgrade dependencies #20

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Conversation

tisonkun
Copy link
Collaborator

This refers to #8

Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


Detailed results are available in [etc/benchmark-result](etc/benchmark-result).

## Supported Rust Versions (MSRV 1.71)

Fastrace is built against the latest stable release. The minimum supported version is 1.80.1. The current Fastrace version is not guaranteed to build on Rust versions earlier than the minimum supported version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's too aggressive to have an MSRV like this. But we can see if it works well and evaluate it as needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background is that, we don't actually define an MSRV before and it's effectively latest stable. Thus, use the current stable version is the least surprising one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reducing MSRV should not be a breaking change IIUC.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this policy.

@andylokandy
Copy link
Collaborator

thread 'test_macro_properties' panicked at fastrace/tests/lib.rs:758:5:
assertion `left == right` failed
  left: "\nroot []\n    bar_async []\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"
 right: "\nroot []\n    bar []\n    bar_async []\n    foo [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"

Seems the same problem as #9 but on linux.

@tisonkun
Copy link
Collaborator Author

@andylokandy Then perhaps merge this one and debugging the macro issue later?

@andylokandy andylokandy merged commit 5c8c23b into main Aug 12, 2024
10 checks passed
@andylokandy andylokandy deleted the msrv branch August 12, 2024 12:08
@andylokandy
Copy link
Collaborator

Then perhaps merge this one and debugging the macro issue later?

Yes, was just waiting for ci to rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants