Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct behavior for weights in chnk.flam.kernbyindex #42

Open
mrachh opened this issue Aug 3, 2023 · 3 comments
Open

Correct behavior for weights in chnk.flam.kernbyindex #42

mrachh opened this issue Aug 3, 2023 · 3 comments

Comments

@mrachh
Copy link
Member

mrachh commented Aug 3, 2023

@jghoskins @askhamwhat @danfortunato

What should the correct behavior for weights in chnk.flam.kernbyindex? Currently it expects the user to provide weights properly concatenated according opdims of various kernels. I have a version, that just acts on weights of the chnkrs and then fixes the opdims stuff inside the subroutine.

This will affect the implementation in chnk.flam.chunkerflam.

@danfortunato
Copy link
Collaborator

I think that the chunker object should store its own weights. Therefore the user should not have to pass any weights to chnk.flam.kernbyindex, and the weights stored in the chunker object will be used automatically. Then inside the subroutine, we can take the chunker-stored weights and expand them to have opdims compatible size.

@askhamwhat
Copy link
Member

I think @danfortunato is right. Weights should be like normals in this sense. Ready to go. Probably won't be too hard to pull through, but chunkerfunc and chunkerpoly will have to be updated.

@jghoskins
Copy link
Collaborator

I agree - as much as possible weights should be hidden from the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants