Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SnapshotHelper.swift resource, handle external file #2

Open
janpio opened this issue Aug 9, 2017 · 3 comments
Open

Remove SnapshotHelper.swift resource, handle external file #2

janpio opened this issue Aug 9, 2017 · 3 comments

Comments

@janpio
Copy link
Collaborator

janpio commented Aug 9, 2017

See: /lib/fastlane/plugin/ionic_integration/resources/ios/ui-snapshots/
This should not be here in this repo, but gotten somehow from snapshot or via calling another action to be up to date.

@janpio janpio changed the title resources should not be "hardcoded" into repo SnapshotHelper.swift should not be "hardcoded" into repo Aug 3, 2018
@janpio
Copy link
Collaborator Author

janpio commented Aug 6, 2018

File is in an guessable location in 99.9% of cases: fastlane/SnapshotHelper.swift.
If it is not, we can ask the user to run fastlane snapshot init or fastlane snapshot update.

@janpio
Copy link
Collaborator Author

janpio commented Aug 6, 2018

Actually, SnapshotHelper.swift is fully handled by snapshot itself, we don't need to handle the file at all.

@janpio janpio changed the title SnapshotHelper.swift should not be "hardcoded" into repo Remove SnapshotHelper.swift Aug 6, 2018
@janpio
Copy link
Collaborator Author

janpio commented Aug 6, 2018

We would only have to be able to find out the actual path of the file it gets linked into our UI Test Target as well.

@janpio janpio changed the title Remove SnapshotHelper.swift Remove SnapshotHelper.swift resource, handle external file Aug 6, 2018
@janpio janpio added the iOS label Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant