From 8d53ff3c2a4e71fd29fbf7a061410edd9dfcc882 Mon Sep 17 00:00:00 2001
From: Ferran Buireu <fbuireu@gmail.com>
Date: Sun, 29 Sep 2024 09:25:35 +0200
Subject: [PATCH] fix: json-ld format

---
 src/pages/index.astro                         |  1 -
 .../components/breadcrumbs/Breadcrumbs.astro  | 37 ++++++++++---------
 2 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/src/pages/index.astro b/src/pages/index.astro
index 5b1b3acf..c355d542 100644
--- a/src/pages/index.astro
+++ b/src/pages/index.astro
@@ -7,7 +7,6 @@ import Testimonials from "@modules/home/components/testimonials/Testimonials.ast
 import Welcome from "@modules/home/components/welcome/Welcome.astro";
 
 // table of contents (details on mobile)
-// check jsonLD (https://jsonld.com/social-network-profiles/)
 // check responsive
 // todo: add signature email
 // todo: add small transitions & animations
diff --git a/src/ui/modules/core/components/breadcrumbs/Breadcrumbs.astro b/src/ui/modules/core/components/breadcrumbs/Breadcrumbs.astro
index bb094b47..7758c86d 100644
--- a/src/ui/modules/core/components/breadcrumbs/Breadcrumbs.astro
+++ b/src/ui/modules/core/components/breadcrumbs/Breadcrumbs.astro
@@ -1,12 +1,12 @@
 ---
-import { breadcrumbDTO } from "@application/dto/breadcrumb/breadcrumbDTO";
-import { getLocation } from "@modules/core/utils/getLocation";
-import "./breadcrumbs.css";
-
-const { pathname: currentPath, origin: originPath } = Astro.url;
-
-const breadcrumbs = breadcrumbDTO.create({ currentPath });
-const location = getLocation(Astro.url);
+import { breadcrumbDTO } from "@application/dto/breadcrumb/breadcrumbDTO";
+import { getLocation } from "@modules/core/utils/getLocation";
+import "./breadcrumbs.css";
+
+const { pathname: currentPath, origin: originPath } = Astro.url;
+
+const breadcrumbs = breadcrumbDTO.create({ currentPath });
+const location = getLocation(Astro.url);
 ---
 <section class:list={[`breadcrumbs__wrapper common-wrapper`, { [`--is-${location}`]: location}]}>
 <ul class="breadcrumbs__list flex justify-center align-center font-sans-serif">
@@ -20,17 +20,20 @@ const location = getLocation(Astro.url);
             ) : (
             <strong class="--is-current-page">{label}</strong>
             )}
-          <script is:inline type="application/ld+json" set:html={JSON.stringify({
-            "@context": "https://schema.org",
-            "@type": "ListItem",
-            "position": index + 1,
-            "item": {
-              "@id": `${originPath}${link}`,
-              "name": label
-            }
-          })}/>
         </li>
       );
     })}
+    <script is:inline type="application/ld+json" set:html={JSON.stringify({
+      "@context": "https://schema.org",
+      "@type": "BreadcrumbList",
+      "itemListElement": breadcrumbs.map(({ link, label }, index) => ({
+        "@type": "ListItem",
+        "position": index + 1,
+        "item": {
+          "@id": `${originPath}${link}`,
+          "name": label
+        }
+      }))
+    })}/>
 </ul>
 </section>