From a9ccd095e86aae15a6924d9d94b63447283d9454 Mon Sep 17 00:00:00 2001
From: Ferran <fbuireu@gmail.com>
Date: Mon, 26 Aug 2024 17:00:02 +0200
Subject: [PATCH] perf: hardcoded strings unification

---
 astro.config.ts                                       |  5 ++++-
 src/const/const.ts                                    |  2 +-
 src/pages/index.astro                                 |  1 -
 src/pages/projects.astro                              | 10 ++++++++++
 .../aboutLatestArticles/AboutLatestArticles.astro     |  2 +-
 src/ui/modules/home/components/myWork/MyWork.astro    | 11 ++++++-----
 6 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/astro.config.ts b/astro.config.ts
index 4411ef5e..c88ee8eb 100644
--- a/astro.config.ts
+++ b/astro.config.ts
@@ -131,7 +131,10 @@ export default defineConfig({
 		}),
 	],
 	redirects: {
-		"/home": "/",
+		"/home": {
+			status: 301,
+			destination: "/",
+		},
 	},
 	output: "hybrid",
 	adapter: cloudflare({
diff --git a/src/const/const.ts b/src/const/const.ts
index a7b58b93..f5f8a20b 100644
--- a/src/const/const.ts
+++ b/src/const/const.ts
@@ -22,7 +22,7 @@ export const PAGES_ROUTES = {
 	[Pages.ABOUT]: "/about",
 	[Pages.TAGS]: "/tags",
 	[Pages.CONTACT]: "/contact",
-	[Pages.PROJECTS]: "/contact",
+	[Pages.PROJECTS]: "/projects",
 	[Pages.TERMS_AND_CONDITIONS]: "/terms-and-conditions",
 	[Pages.PRIVACY_POLICY]: "/privacy-policy",
 	[Pages.HOME]: "/",
diff --git a/src/pages/index.astro b/src/pages/index.astro
index 70832a2b..13fe86de 100644
--- a/src/pages/index.astro
+++ b/src/pages/index.astro
@@ -7,7 +7,6 @@ import Welcome from "@modules/home/components/welcome/Welcome.astro";
 
 // todo: check metadata all pages
 // todo: add small transitions & animations
-//        - CTAs with arrow: animate arrow
 //        - Latest articles (https://codepen.io/jh3y/pen/MWLyGxo)
 // todo: wait for wrangler webhook -->  add Algolia + filters (+ URL filtering) https://www.algolia.com/developers/contentful-search-algolia/ (webhook problem)
 // todo: how to deploy cloudfare pages
diff --git a/src/pages/projects.astro b/src/pages/projects.astro
index a712be53..a1d23234 100644
--- a/src/pages/projects.astro
+++ b/src/pages/projects.astro
@@ -4,6 +4,7 @@ import { getCollection } from "astro:content";
 import BaseLayout from "@modules/core/components/baseLayout/BaseLayout.astro";
 import ProjectSection from "@modules/projects/components/projectSection/ProjectSection.astro";
 import ProjectsIntro from "@modules/projects/components/projectsIntro/ProjectsIntro.astro";
+import { PAGES_ROUTES } from 'src/const';
 
 const projects = await getCollection("projects");
 ---
@@ -21,6 +22,15 @@ const projects = await getCollection("projects");
           <article set:html={project.data.description} />
         </div>
       </article>
+        <script is:inline type="application/ld+json" set:html={JSON.stringify({
+          '@context': 'https://schema.org',
+          '@type': 'ItemList',
+          'itemListElement': {
+            '@type': 'ListItem',
+            'position': index + 1,
+            'url': new URL(`${PAGES_ROUTES.projects}#${project.data.id}#${project.data.id}`, Astro.url).href,
+          },
+        })} />
     </ProjectSection>
   ))}
 </BaseLayout>
diff --git a/src/ui/modules/about/components/aboutLatestArticles/AboutLatestArticles.astro b/src/ui/modules/about/components/aboutLatestArticles/AboutLatestArticles.astro
index 5500ba6d..a28d1e5e 100644
--- a/src/ui/modules/about/components/aboutLatestArticles/AboutLatestArticles.astro
+++ b/src/ui/modules/about/components/aboutLatestArticles/AboutLatestArticles.astro
@@ -9,7 +9,7 @@ const articles = await getCollection("articles");
 
 <section class="about-latest-articles__wrapper common-wrapper">
   <h3 class="about-latest-articles__title section-title">
-    Fresh from <a class="clickable" href={`${PAGES_ROUTES.articles}`}>the blog</a>
+    Fresh from <a class="clickable underline-on-action" href={`${PAGES_ROUTES.articles}`}>the blog</a>
   </h3>
   <div class="about-latest-articles__inner">
     <div class="about-latest-articles__quote__wrapper">
diff --git a/src/ui/modules/home/components/myWork/MyWork.astro b/src/ui/modules/home/components/myWork/MyWork.astro
index 947f0653..eb639a46 100644
--- a/src/ui/modules/home/components/myWork/MyWork.astro
+++ b/src/ui/modules/home/components/myWork/MyWork.astro
@@ -2,6 +2,7 @@
 import { Image } from "astro:assets";
 import { getCollection } from "astro:content";
 import "./my-work.css";
+import { PAGES_ROUTES } from 'src/const';
 
 const projects = await getCollection("projects");
 ---
@@ -10,9 +11,10 @@ const projects = await getCollection("projects");
   <h3 class="my-work__title section-title">My Work</h3>
   <ul class="my-work__content__list flex row-wrap justify-space-between">
     {projects.map((project, index) => {
-      return (
-        <li class="my-work__item">
-          <a class="my-work__item__link clickable" href={`/projects#${project.data.id}`}>
+      const projectUrl=`${PAGES_ROUTES.projects}#${project.data.id}#${project.data.id}`
+
+        return <li class="my-work__item">
+          <a class="my-work__item__link clickable" href={projectUrl}>
             <Image
               src={project.data.image.url}
               alt={project.data.name}
@@ -28,10 +30,9 @@ const projects = await getCollection("projects");
           'itemListElement': {
             '@type': 'ListItem',
             'position': index + 1,
-            'url': new URL(`${Astro.url}projects#${project.data.id}`, Astro.url).href,
+            'url': new URL(projectUrl, Astro.url).href,
           },
         })} />
-      );
     })}
   </ul>
 </section>