Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalized network related resource in cloud pinyin when it is not used. #188

Open
wengxt opened this issue Jul 31, 2024 · 0 comments
Open

Comments

@wengxt
Copy link
Member

wengxt commented Jul 31, 2024

curl 8.9.0 (not link the upstream link here to avoid spamming in github since upstream already fixed it) was causing issue to make event monitoring on curl into busy loop.

However, disable cloudpinyin (with hotkey or from configtool), doesn't work as a mitigation, since we do not do any curl related clean up when it is disabled. When cloudpinyin is disabled, we just simply don't send any new request.

The reason that why it is implemented in this way, is because, in fcitx5 we moved the cloudpinyin's enable/disable from module to engine. Thus module doesn't have a way to track, whether cloudpinyin "may" be used in near future, or not.

We should consider implement something, that can clean up all the resources on cloudpinyin and only initialize them when needed. It only involves a thread creation and some struct initialization in curl, which should be cheap if we don't always keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant