Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this work with the location-based method? #15

Open
ediejm opened this issue Apr 30, 2021 · 3 comments
Open

Can this work with the location-based method? #15

ediejm opened this issue Apr 30, 2021 · 3 comments

Comments

@ediejm
Copy link

ediejm commented Apr 30, 2021

Not really an issue just a question! This is super cool and I am excited to have come across it, it works really well. Thank you!

I did try applying it to a location-based object (i.e. no marker) and it doesn't work with that. I know you've not suggested that it should, but I wondered if there's any way to make it work with location-based or would that be impossible?

@fcor
Copy link
Owner

fcor commented May 17, 2021

Hi! Sorry for my late response, did you try it with location based? I haven't used it there but I think It should work since the transformations are applied at a-scene level.

@AdamVI2
Copy link

AdamVI2 commented Jun 8, 2022

Actually it didn't work for me by default in case of location based. Both functions: handleRotation and handleScale require an object to be visible (this.visible), while visibility is (by default) set only with markerFound listeners (and those are not being triggered obviously in case of location based).

I would suggest adding to registerComponent("gesture-handler") schema:

locationBased: { default: false},

and then alternating init: function() line:

this.isVisible = false;

to

this.isVisible = this.data.locationBased;

With that setup we can use

gesture-handler="locationBased: true"

in our object's options. At least I did that and it worked fo me :)
Hope this helps!

@fcor
Copy link
Owner

fcor commented Jun 13, 2022

Nice! Feel free to create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants