Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROOMSTATE should avoid empty string for certain tags #172

Open
iProdigy opened this issue Feb 3, 2021 · 0 comments
Open

ROOMSTATE should avoid empty string for certain tags #172

iProdigy opened this issue Feb 3, 2021 · 0 comments
Assignees
@trezy
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@iProdigy
Copy link
Contributor

iProdigy commented Feb 3, 2021

Describe the bug
fdgt sends:

@emote-only=;followers-only=;r9k=;rituals=;room-id=6210de37-d0b4-457c-b0e1-bd81991bd3b8;slow=;subs-only= :tmi.twitch.tv ROOMSTATE #ogprodigy

Twitch would send:

@emote-only=0;followers-only=-1;r9k=0;rituals=0;room-id=493418343;slow=0;subs-only=0 :tmi.twitch.tv ROOMSTATE #ogprodigy

Some libraries parse tags like followers-only and slow to numbers without checking for an empty string, causing an error to be thrown

To Reproduce
Open irc connection and join a channel

Expected behavior
If followers-only is disabled, -1 should be sent, not empty string
If slow mode is disabled, it would be nice if 0 was sent instead of an empty string
etc.
@iProdigy iProdigy added the type: bug Something isn't working label Feb 3, 2021
@trezy trezy added the good first issue Good for newcomers label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trezy trezy

Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trezy @iProdigy