Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract-blob-store as a dependency #92

Open
clintonb opened this issue Nov 7, 2021 · 4 comments
Open

Add abstract-blob-store as a dependency #92

clintonb opened this issue Nov 7, 2021 · 4 comments

Comments

@clintonb
Copy link

clintonb commented Nov 7, 2021

See #81. If abstract-blob-store is needed to compile the project, abstract-blob-store should be a production dependency. It's currently a development dependency, so not installed when used in other projects.

@claustres
Copy link
Collaborator

I am not a typescript expert but as far as I can see a dependence has been added in the types definition. However, from the JS code perspective this dependency is only used in tests (so as a dev dependency). @daffl probably knows how to fix this.

@daffl
Copy link
Member

daffl commented Nov 8, 2021

I'd say that everything that is required in the production types file should be a production dependency. An alternative (since abstract-blob-store is really just a test harness) would be to add the Abstract Blob store types from https://github.com/maxogden/abstract-blob-store/blob/master/index.d.ts directly in the typings file here.

@claustres
Copy link
Collaborator

I agree, I am not a typescript fan but IMHO using it implies that we should depend on the interface so that if it is changed it will break at compilation time.

@daffl
Copy link
Member

daffl commented Nov 8, 2021

Moving abstract-blob-store from devDependencies into dependencies should do it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants