Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort property not available on objects raises an error #214

Open
claustres opened this issue Aug 3, 2023 · 0 comments
Open

Sort property not available on objects raises an error #214

claustres opened this issue Aug 3, 2023 · 0 comments

Comments

@claustres
Copy link
Contributor

Steps to reproduce

Use a sort query referring a property which is not retrieved in the target objects, ie the property does exist in the database but is discarded for the client or not selected with $select.

Expected behavior

Reactivity should work fine.

Actual behavior

An error is raised and breaks reactivity: TypeError: Cannot read properties of undefined (reading 'name') at eval (feathers-reactive.js:1555:1).

It appears that the sorter does not check if the property is available on the target object when accessing it.

System configuration

Tell us about the applicable parts of your setup.

Module versions (especially the part that's not working): 0.10

NodeJS version: 16

Operating System: Debian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant