Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindWithDispatch arguments order #41

Open
bertho-zero opened this issue Nov 28, 2017 · 3 comments
Open

bindWithDispatch arguments order #41

bertho-zero opened this issue Nov 28, 2017 · 3 comments

Comments

@bertho-zero
Copy link
Contributor

In the "Autobind Action Creators" part of the readme I see:

const services = bindWithDispatch(store.dispatch, rawServices)

The signature of the redux binder is bindActionCreators(actionCreators, dispatch), so I propose to respect the order of the arguments of the redux doc, ie:

const services = bindWithDispatch(rawServices, store.dispatch)
@eddyystop
Copy link
Collaborator

Wouldn't this be a breaking change?

@subodhpareek18
Copy link
Contributor

Yes, this would be a breaking change, my bad I didn't realize this while adding the method.

@eddyystop
Copy link
Collaborator

You may be right theoretically but I'm not sure its worth the impact of a breaking change.

I'm putting a won't fix label on this as a reminder in case a big refactoring is done someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants