Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Binarizer class #790

Open
d-lazenby opened this issue Aug 14, 2024 · 1 comment
Open

Add a Binarizer class #790

d-lazenby opened this issue Aug 14, 2024 · 1 comment

Comments

@d-lazenby
Copy link

A clear and concise description of what the problem is.
I needed to binarize some features in a pipeline but saw that this wasn't currently implemented in the package; I instead used the sklearn Binarizer and ColumnTransformer classes. This wasn't ideal as I had to keep track of the new indexes at subsequent steps of the pipeline - one of the nice things about feature engine is that you don't have to worry about that.

Describe the solution you'd like
An implementation of a Binarizer class that bypasses the need for the corresponding sklearn class and that you can use directly within the Pipeline class instead of using ColumnTransformer.

Describe alternatives you've considered
I wrote a class that inherits from the BaseDiscretizer which works as described above.

Would it be OK for me to work on this and open a PR?

@solegalli
Copy link
Collaborator

Hey @d-lazenby ! Thanks for the suggestion! You are more than welcome to create a PR! I'll stay on the look out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants