From d466eb95a37ecc324fd09ce8046e22ec74cb6c5c Mon Sep 17 00:00:00 2001 From: Daniil Sapa Date: Sat, 11 Jan 2025 15:53:14 +0200 Subject: [PATCH] Try to fix the size workflows --- .github/workflows/bundle-size-trusted.yaml | 6 +++++- .github/workflows/bundle-size-untrusted.yaml | 10 +++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bundle-size-trusted.yaml b/.github/workflows/bundle-size-trusted.yaml index 8ff1e31..64871f4 100644 --- a/.github/workflows/bundle-size-trusted.yaml +++ b/.github/workflows/bundle-size-trusted.yaml @@ -25,6 +25,10 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} run-id: ${{ github.event.workflow_run.id }} + - name: Sanitize branch name + id: sanitize_branch + run: echo "::set-output name=stanitized::$(echo ${{ toJson(github.base_ref) }} | sed 's/[^0-9a-zA-Z\._\-]/_/g')" + - name: Create the report id: create-report uses: actions/github-script@v7 @@ -48,7 +52,7 @@ jobs: } const fs = require('fs'); const sizes = parseDuOutput(fs.readFileSync(`sizes-${${{ toJson(github.base_ref) }}}.txt`, 'utf8')); - const sizesPR = parseDuOutput(fs.readFileSync(`sizes-${${{ toJson(github.head_ref) }}}.txt`, 'utf8')); + const sizesPR = parseDuOutput(fs.readFileSync(`sizes-${${{ steps.sanitize_branch.outputs.sanitized }}}.txt`, 'utf8')); core.summary.addHeading('📊 Package size report', '3'); core.summary.addTable([ ['Package', 'Before', 'After'].map((data) => ({ data, header: true })), diff --git a/.github/workflows/bundle-size-untrusted.yaml b/.github/workflows/bundle-size-untrusted.yaml index 8cbddee..49daab7 100644 --- a/.github/workflows/bundle-size-untrusted.yaml +++ b/.github/workflows/bundle-size-untrusted.yaml @@ -27,6 +27,10 @@ jobs: with: ref: ${{ matrix.branch }} + - name: Sanitize branch name + id: sanitize_branch + run: echo "::set-output name=stanitized::$(echo ${{ matrix.branch }} | sed 's/[^0-9a-zA-Z\._\-]/_/g')" + - name: Setup uses: ./.github/actions/setup @@ -35,10 +39,10 @@ jobs: - name: Collect sizes in bytes id: sizes - run: du -sb packages/*/dist > sizes-${{ matrix.branch }}.txt + run: du -sb packages/*/dist > sizes-${{ steps.sanitize_branch.outputs.sanitized }}.txt - name: Upload the sizes uses: actions/upload-artifact@v4 with: - name: sizes-${{ matrix.branch }} - path: sizes-${{ matrix.branch }}.txt + name: sizes-${{ steps.sanitize_branch.outputs.sanitized }} + path: sizes-${{ steps.sanitize_branch.outputs.sanitized }}.txt