You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When choosing which one to use (Equatable or EquatableMixin) there is no benefit of choosing Equatable (or I am failing to see one) over the mixin version. This duplicates the API for no clear reason to me.
Describe the solution you'd like
Removing the non-mixin version. This simplifies this package, docs, and usage.
Additional context
During code reviews I often have to tell people to use the mixin version instead, since it is more extensible (for example will allow in the future to extend some other class).
If I am missing some advantage that the class version has, please let me know what that is and feel free to close this issue.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
When choosing which one to use (
Equatable
orEquatableMixin
) there is no benefit of choosingEquatable
(or I am failing to see one) over the mixin version. This duplicates the API for no clear reason to me.Describe the solution you'd like
Removing the non-mixin version. This simplifies this package, docs, and usage.
Additional context
During code reviews I often have to tell people to use the mixin version instead, since it is more extensible (for example will allow in the future to extend some other class).
If I am missing some advantage that the class version has, please let me know what that is and feel free to close this issue.
The text was updated successfully, but these errors were encountered: