Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equatable is redundant with EquatableMixin #160

Closed
shilangyu opened this issue Apr 27, 2023 · 3 comments
Closed

Equatable is redundant with EquatableMixin #160

shilangyu opened this issue Apr 27, 2023 · 3 comments

Comments

@shilangyu
Copy link

Is your feature request related to a problem? Please describe.

When choosing which one to use (Equatable or EquatableMixin) there is no benefit of choosing Equatable (or I am failing to see one) over the mixin version. This duplicates the API for no clear reason to me.

Describe the solution you'd like

Removing the non-mixin version. This simplifies this package, docs, and usage.

Additional context

During code reviews I often have to tell people to use the mixin version instead, since it is more extensible (for example will allow in the future to extend some other class).

If I am missing some advantage that the class version has, please let me know what that is and feel free to close this issue.

@utamori
Copy link

utamori commented Jun 2, 2023

I think this can be solved by making Equatable an Dart3 abstract mixin class.
EquatableMixin should be deprecated and removed later.
#161

@felangel
Copy link
Owner

Closing this since it will be resolved by #175

@ricardodalarme
Copy link

Now that Macros has been discontinued, it would be a good idea to reopen this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants