Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document spin_app::App.id gurantees #2852

Open
rylev opened this issue Sep 20, 2024 · 0 comments
Open

Document spin_app::App.id gurantees #2852

rylev opened this issue Sep 20, 2024 · 0 comments

Comments

@rylev
Copy link
Collaborator

rylev commented Sep 20, 2024

spin_app::App.id is used in the Spin codebase almost exclusively for logging. The only place where it somewhat matters what the id is is in the Redis trigger where it used for telemetry. I feel somewhat uncomfortable that the id is somewhat assumed to be unique to the application, but it's not documented anywhere. Perhaps we want to be clearer about what gurantees users of the id can be sure of, and what callers of spin_app::App::new should try to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant