From 973326171b1ca59d2ab049a6fa598b445d20e41a Mon Sep 17 00:00:00 2001 From: Andrew Jiang Date: Thu, 10 Oct 2024 20:52:47 -0400 Subject: [PATCH] fixes --- servers/fdr/src/__test__/local/services/docs.test.ts | 1 + servers/fdr/src/__test__/local/services/docsCache.test.ts | 1 + .../src/__test__/local/services/snippetsByEndpointId.test.ts | 1 + servers/fdr/src/controllers/docs/v1/getDocsReadService.ts | 2 +- servers/fdr/src/healthchecks/checkRedis.ts | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/servers/fdr/src/__test__/local/services/docs.test.ts b/servers/fdr/src/__test__/local/services/docs.test.ts index 6c385d7003..33dc2663ea 100644 --- a/servers/fdr/src/__test__/local/services/docs.test.ts +++ b/servers/fdr/src/__test__/local/services/docs.test.ts @@ -11,6 +11,7 @@ export const WRITE_DOCS_REGISTER_DEFINITION: DocsV1Write.DocsDefinition = { items: [], landingPage: undefined, }, + root: undefined, typography: { headingsFont: { name: "Syne", diff --git a/servers/fdr/src/__test__/local/services/docsCache.test.ts b/servers/fdr/src/__test__/local/services/docsCache.test.ts index fa4d38a128..c82b8e2876 100644 --- a/servers/fdr/src/__test__/local/services/docsCache.test.ts +++ b/servers/fdr/src/__test__/local/services/docsCache.test.ts @@ -9,6 +9,7 @@ export const WRITE_DOCS_REGISTER_DEFINITION: DocsV1Write.DocsDefinition = { items: [], landingPage: undefined, }, + root: undefined, title: undefined, defaultLanguage: undefined, announcement: undefined, diff --git a/servers/fdr/src/__test__/local/services/snippetsByEndpointId.test.ts b/servers/fdr/src/__test__/local/services/snippetsByEndpointId.test.ts index 7fc80cebb0..86dfb81e97 100644 --- a/servers/fdr/src/__test__/local/services/snippetsByEndpointId.test.ts +++ b/servers/fdr/src/__test__/local/services/snippetsByEndpointId.test.ts @@ -111,6 +111,7 @@ it("Load snippets by endpoint id", async () => { } satisfies DocsV1Write.NavigationItem, ], }, + root: undefined, title: undefined, defaultLanguage: undefined, announcement: undefined, diff --git a/servers/fdr/src/controllers/docs/v1/getDocsReadService.ts b/servers/fdr/src/controllers/docs/v1/getDocsReadService.ts index b3543590ee..dc197e4b17 100644 --- a/servers/fdr/src/controllers/docs/v1/getDocsReadService.ts +++ b/servers/fdr/src/controllers/docs/v1/getDocsReadService.ts @@ -211,7 +211,7 @@ function getSearchInfoFromDocs({ docsDbDefinition: DocsV1Db.DocsDefinitionDb; app: FdrApplication; }): Algolia.SearchInfo { - if (indexSegmentIds == null) { + if (indexSegmentIds == null || docsDbDefinition.config.navigation == null) { return { type: "legacyMultiAlgoliaIndex", algoliaIndex }; } return visitDbNavigationConfig(docsDbDefinition.config.navigation, { diff --git a/servers/fdr/src/healthchecks/checkRedis.ts b/servers/fdr/src/healthchecks/checkRedis.ts index ca6820b288..9822e6f173 100644 --- a/servers/fdr/src/healthchecks/checkRedis.ts +++ b/servers/fdr/src/healthchecks/checkRedis.ts @@ -20,6 +20,7 @@ const HEALTHCHECK_DOCS_RESPONSE: CachedDocsResponse = { items: [], landingPage: undefined, }, + root: undefined, title: undefined, defaultLanguage: undefined, announcement: undefined,