Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret for tenants #14

Open
KennethFoliWork opened this issue Feb 28, 2022 · 3 comments
Open

Secret for tenants #14

KennethFoliWork opened this issue Feb 28, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@KennethFoliWork
Copy link

I am testing your plugin and i is working fine for me
but i have a Feature request and that is that if you can add the the funktion
so that you can add secret to Tenants for customer with secrets

@mraerino
Copy link
Member

I feel like this is a valid request.

Can you tell me more about the use case though?
Is this for per-tenant login credentials, e.g. on DSL lines?

@mraerino mraerino changed the title Feature request Secret for tenants Apr 18, 2022
@mraerino mraerino added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 18, 2022
@KennethFoliWork
Copy link
Author

yes it is for logins there is use for the per-tenant for logins for accounts there is global used
we have a update system where som of the tinformation is pr tenant and i like to store it in tenant

@danielperna84
Copy link

Hi,

I'm new to Netbox and have just stumbled upon this issue while looking for a Vault integration. That being said, I want to contribute some input to this issue:

  1. Vault (Enterprise) supports the concept of Namespaces. If there was a boolean option to support namespaces and the namespaces in Vault match f. ex. the tenant-slugs, then this would probably be rather trivial to implement, as the tenant-slug would just have to be prefixed to the request that's already being made (I believe). However, this would not support nested Vault namespaces I assume. But still probably a step forward.
  2. In my case I actually store different tenants in separate KV-storages, not utilizing the namespaces feature. I assume the kv_mount_path option could support a special value like $tenant_slug / $tenant_id, which replaces the typically static mount-path with /{tenant-slug} per request depending on the tenant of the currently viewed item.

Being new to this I don't know if those 2 options actually make sense. But I wanted to share those ideas anyways to bring this issue forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
3 participants