Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: howto_rl_mb_001_grid_world_environment.py fails #1140

Closed
3 tasks
detlefarend opened this issue Feb 24, 2025 · 6 comments · Fixed by #1142
Closed
3 tasks

Bug: howto_rl_mb_001_grid_world_environment.py fails #1140

detlefarend opened this issue Feb 24, 2025 · 6 comments · Fixed by #1142
Assignees
Labels
admin Administrative task bug Something isn't working quality Quality assurance

Comments

@detlefarend
Copy link
Member

1 Describe the bug
A clear and concise description of what the bug is.

2 To Reproduce
Steps to reproduce the behavior:

  1. Run the mentioned howto...

3 Expected behavior
A clear and concise description of what you expected to happen.

4 Screenshots
If applicable, add screenshots to help explain your problem.

5 Additional Informations

5.1 Operating System

  • Linux
  • Windows
  • Mac OS
@detlefarend detlefarend added admin Administrative task bug Something isn't working quality Quality assurance labels Feb 24, 2025
@detlefarend
Copy link
Member Author

Hi @steveyuwono, could you please take a look? Thx!!

@steveyuwono
Copy link
Contributor

Hi @detlefarend , this is weird that it happens only on Ubuntu with Python 3.10. But anyway I will check this later...

@steveyuwono
Copy link
Contributor

Hi @detlefarend ,

I have observed that the error occurs within PyTorch’s TorchDynamo, which seems to be attempting to use Self in a type annotation. In our Unittest, this issue arises with Python 3.10 after the release of PyTorch 2.6.0. However, when I set the PyTorch version to <2.6.0, the Unittest ran without any issues.

According to the official release notes (https://github.com/pytorch/pytorch/blob/main/RELEASE.md), there should be no compatibility issues with Python 3.10. I have also tested the setup on my PC using both Windows and Ubuntu under Python 3.10, and I did not encounter any errors. This suggests that the issue might be specific to the Python 3.10 environment in the Unittest.

What should we do here? We can either limit the PyTorch version below 2.6.0 or deactivate the related howto.

@steveyuwono steveyuwono linked a pull request Feb 25, 2025 that will close this issue
@detlefarend
Copy link
Member Author

detlefarend commented Feb 25, 2025

Hi @detlefarend ,

I have observed that the error occurs within PyTorch’s TorchDynamo, which seems to be attempting to use Self in a type annotation. In our Unittest, this issue arises with Python 3.10 after the release of PyTorch 2.6.0. However, when I set the PyTorch version to <2.6.0, the Unittest ran without any issues.

According to the official release notes (https://github.com/pytorch/pytorch/blob/main/RELEASE.md), there should be no compatibility issues with Python 3.10. I have also tested the setup on my PC using both Windows and Ubuntu under Python 3.10, and I did not encounter any errors. This suggests that the issue might be specific to the Python 3.10 environment in the Unittest.

What should we do here? We can either limit the PyTorch version below 2.6.0 or deactivate the related howto.

Hi @steveyuwono, let's exclude 2.6.0 from the requirements. I can take over.

@detlefarend detlefarend linked a pull request Feb 25, 2025 that will close this issue
@detlefarend detlefarend self-assigned this Feb 25, 2025
@steveyuwono
Copy link
Contributor

Hi @detlefarend ,
I have observed that the error occurs within PyTorch’s TorchDynamo, which seems to be attempting to use Self in a type annotation. In our Unittest, this issue arises with Python 3.10 after the release of PyTorch 2.6.0. However, when I set the PyTorch version to <2.6.0, the Unittest ran without any issues.
According to the official release notes (https://github.com/pytorch/pytorch/blob/main/RELEASE.md), there should be no compatibility issues with Python 3.10. I have also tested the setup on my PC using both Windows and Ubuntu under Python 3.10, and I did not encounter any errors. This suggests that the issue might be specific to the Python 3.10 environment in the Unittest.
What should we do here? We can either limit the PyTorch version below 2.6.0 or deactivate the related howto.

Hi @steveyuwono, let's exclude 2.6.0 from the requirements. I can take over.

Okay, thank you. Then, I will delete my branch.

@detlefarend
Copy link
Member Author

Hi @detlefarend ,
I have observed that the error occurs within PyTorch’s TorchDynamo, which seems to be attempting to use Self in a type annotation. In our Unittest, this issue arises with Python 3.10 after the release of PyTorch 2.6.0. However, when I set the PyTorch version to <2.6.0, the Unittest ran without any issues.
According to the official release notes (https://github.com/pytorch/pytorch/blob/main/RELEASE.md), there should be no compatibility issues with Python 3.10. I have also tested the setup on my PC using both Windows and Ubuntu under Python 3.10, and I did not encounter any errors. This suggests that the issue might be specific to the Python 3.10 environment in the Unittest.
What should we do here? We can either limit the PyTorch version below 2.6.0 or deactivate the related howto.

Hi @steveyuwono, let's exclude 2.6.0 from the requirements. I can take over.

Okay, thank you. Then, I will delete my branch.

Sry, I didn't recognize that you already created a branch for it. I changed the requirements in branch final_changes_v2.0.0 and it perfectly solved the problem. Thank you for analyzing the problem!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Administrative task bug Something isn't working quality Quality assurance
Projects
None yet
2 participants