Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deliberate error thrown in sDNA/sdna_vs2008/dijkstra.cpp when compiling off of MSVC, for C++ standards post '98. #52

Open
JamesParrott opened this issue Jun 9, 2024 · 1 comment
Open

Deliberate error thrown in sDNA/sdna_vs2008/dijkstra.cpp when compiling off of MSVC, for C++ standards post '98. #52

JamesParrott opened this issue Jun 9, 2024 · 1 comment

Comments

@JamesParrott
Copy link
Collaborator

JamesParrott commented Jun 9, 2024 •
edited
Loading

What did I break?! To compile sDNA using Zig ('clang') I commented out these three lines:

		// #if __cplusplus > 199711L
		// 	#error priority queue behaviour has changed - sort out the next line for it+1
		// #endif

sdna_plus/sDNA/sdna_vs2008/dijkstra.cpp

Line 78 in 9d73c6c

#if __cplusplus > 199711L 


// Here be Dragons!
@JamesParrott
Copy link
Collaborator Author

Removed with #74 on Cross_Platform branch

Does not cause a test failure in either Visual Studio build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesParrott