Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Activity Timeline #302

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

199ocero
Copy link
Contributor

@199ocero 199ocero commented Jan 7, 2024

Activity Timeline plugin conveniently presents upcoming, ongoing, and past activities, offering a comprehensive view of events.

Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Could you please ensure that image URLs in your plugin's README file are absolute URLs rather than relative links? Then we can embed them on our website correctly. Thanks!

Please let us know when you've addressed these issues.

@199ocero
Copy link
Contributor Author

199ocero commented Jan 9, 2024

Hi @saade , my plugins image url is already updated in my read me. Thank youuu!

@199ocero 199ocero requested a review from saade January 9, 2024 22:06
Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Your plugin's README is loaded into the plugin page on the Filament website. There is now a duplicate image on your page, as it also exists in your documentation. You can remove it from the Filament website by giving it a filament-hidden class, so then it is only shown once.

@saade saade merged commit 0817c55 into filamentphp:main Jan 11, 2024
@199ocero 199ocero deleted the jaocero-activity-timeline-v1 branch January 17, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants