Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap is inserting corrupted metadata into sectors_meta #191

Open
magik6k opened this issue Sep 4, 2024 · 2 comments
Open

Snap is inserting corrupted metadata into sectors_meta #191

magik6k opened this issue Sep 4, 2024 · 2 comments

Comments

@magik6k
Copy link
Collaborator

magik6k commented Sep 4, 2024

The title is bad news

Good news:

  • We can very easily tell which entries are affected
  • We have all required metadata needed to repair in the database
  • Initial fix will be in Unseal #181
  • It doesn't affect anything important, other than unsealing
    • For now it will have a workaround, but we'll eventually need to ship a full fix with some repair migration
@magik6k
Copy link
Collaborator Author

magik6k commented Sep 4, 2024

Source of the issue: 4445520

magik6k added a commit that referenced this issue Sep 4, 2024
@magik6k
Deal with #191
90330bf
magik6k added a commit that referenced this issue Sep 4, 2024
@magik6k
Deal with #191
a0b3dd7
@LexLuthr
Copy link
Contributor

LexLuthr commented Sep 4, 2024

How do we plan to generate the unsealed CID for affected sectors? Is it same as SDR or do we have to run EncodeInto?

magik6k added a commit that referenced this issue Sep 4, 2024
@magik6k
Deal with #191
24bd803
magik6k added a commit that referenced this issue Sep 6, 2024
@magik6k
Deal with #191
69c3e24
magik6k added a commit that referenced this issue Sep 16, 2024
@magik6k
Unseal (#181)
b2e2def 
* Start unseal impl

* Complete Generate Key

* Decode SDR func

* most of SDR unseal

* Fix an unholy out-of-order decode issue

* storiface: standardize .tmp somewhat

* make gen

* wip snap

* What

* snap unseal test

* add logging

* phi-only test

* SNAP DECODE WOOOORKS!!!

* cleanup logging

* parallel snap decode

* select rhos on the fly

* snap decode SealCall

* unseal scheduling

* Plumb unseal to curio run

* make: Always build blst

* CLI for managing unseals

* Unseal preference aware GC

* Fix into handling in GenerateSDR

* Oh no, snap is outputting corrupted metadata

* Deal with #191

* make gen

* get unseal fully working

* scrub unsealed command

* fix unseal check

* unseal: Use correct CID in decode

* gc: Don't mark sectors still in unseal pipeline for removal

* unseal pipeline gc

* make gen

* fix snap decode readers

* config: EnableScrubUnsealed->EnableCommP

* harmony: Advanced max counters

* make gen

* address review

* make gen

* harmony: Put max counter Limiter behind an interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magik6k @LexLuthr