Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[venus-messager] set GasOverEstimation not null after related issue is fixed #5467

Closed
11 tasks
Tracked by #5527
LinZexiao opened this issue Nov 11, 2022 · 2 comments
Closed
11 tasks
Tracked by #5527

[venus-messager] set GasOverEstimation not null after related issue is fixed #5467

LinZexiao opened this issue Nov 11, 2022 · 2 comments
Labels
C-Blocked Category: temporarily stuck without a good solution C-enhancement Category: feature enhancement P2 Medium - we should get to this soon

Comments

@LinZexiao
Copy link
Collaborator

链服务模块 / Chain Service Components

  • venus
  • venus-auth
  • venus-gateway
  • venus-messager
  • venus-miner
  • 文档 / docs

订单服务模块 / Deal Service Components

  • venus-market
  • 文档 / docs

算力服务模块 / Storage Power Service Components

  • venus-sector-manager
  • venus-worker
  • 文档 / docs

描述 / Description

message 数据层应该确保 GasOverEstimation 和 GasOverPremium 不为空
但是因为 gorm 自动迁移时,将精度和 not null 组合到一起就会有问题
等关联issue修复之后,再将 not null tag 加上
涉及数据结构 sqliteAddress , MsgMeta
@LinZexiao LinZexiao added C-enhancement Category: feature enhancement P2 Medium - we should get to this soon C-Blocked Category: temporarily stuck without a good solution labels Nov 11, 2022
@diwufeiwen diwufeiwen mentioned this issue Dec 5, 2022
Closed
42 tasks
@Fatman13 Fatman13 mentioned this issue Dec 16, 2022
Closed
36 tasks
@hunjixin
Copy link
Contributor

直接使用sqlite的基础类型real不会有问题。

@LinZexiao
Copy link
Collaborator Author

直接使用sqlite的基础类型real不会有问题。

那是不是 也要改一下代码,另外 MySQL 那边也相应修改?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Blocked Category: temporarily stuck without a good solution C-enhancement Category: feature enhancement P2 Medium - we should get to this soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hunjixin @LinZexiao