emacs26 - install errors

[sth0]

This may be similar to closed issue #1068. But I think it is different. After building the deb package and during the install there are two errors and a lot of suggestions.

Error 1: the file 00fink-vars.el needs to be updated to handle the version 26 changes in syntax. I don't think I saw this when installing emacs25.

in fink-file->string:
opt/sw/etc/emacs26/site-start.d/00fink-vars.el:32:23:Warning: Use
`with-current-buffer' rather than save-excursion+set-buffer

Error 2: Suggestion for updating the fink-startup.el file for changes in syntax.

In fink-run-directories:
opt/sw/share/emacs26/site-lisp/fink-startup.el:131:49:Warning: mapcar' called for effect; use mapc' or `dolist' instead

Not sure if these are fatal flaws nor am I an elisp hacker to try to fix those.

The other issue is a bit curious The message is:

The package emacs26-nox should be rebuilt with new debhelper to get trigger support
Ignoring install-info called from maintainer script

Now debhelper is a fink package but not required for the build process but required for the install process? There is no "InstallDeps" tag AFAIK in the fink universe. Debhelper is current version 12.7.1.

[sth0]

So as a shot, I tried to manually install debhelper. It appears that this is not a popular package or someone else would have noticed that it is missing dependencies?

Reading dependency for debhelper-12.7.1-1...
WARNING: While resolving dependency "dh-strip-nondeterminism >= 0.028" for package "debhelper-12.7.1-1", package "dh-strip-nondeterminism" was not found.
Can't resolve dependency "dh-strip-nondeterminism (>= 0.028)" for package "debhelper-12.7.1-1" (no matching packages/versions found)
Exiting with failure.

This package does not appear in any version of fink distributions.

[nieder]

Those look like warnings that reference outdated functions rather than failures from removed functions. Someone who knows lisp should patch them.

This seems to be the documentation for it: https://www.gnu.org/software/emacs/manual/html_node/elisp/Current-Buffer.html#index-set_002dbuffer

Upstream emacsen-common is now at 3.0.5, but not quite ancient 2.0.8 is still available: https://archive.ubuntu.com/ubuntu/pool/main/e/emacsen-common/

While our version of 00fink-vars.el looks like this:

(defun fink-file->string (name &optional func)
  "Convert a file into a string"
  (interactive "fFile name : ")
  (let ((filename (expand-file-name name)))
    (if (not (file-readable-p filename))
	nil
      (let ((buf (create-file-buffer filename))
	    ret)
	(save-excursion
	  (set-buffer buf)
	  (insert-file-contents filename)
	  (if func (funcall func))
	  (setq ret (buffer-string)))
	(kill-buffer buf)
	ret))))

(defun fink-clean-mailname ()
  (while (search-forward "\n" nil t)
    (replace-match "" nil t)))

In 2.0.8::00debian-vars, it looks like this:

(defun debian-file->string (name &optional func)
  "Convert a file into a string"
  (interactive "fFile name : ")
  (let ((filename (expand-file-name name)))
    (if (not (file-readable-p filename))
        nil
      (with-temp-buffer
        ;; Do not run any user `find-file-hooks'
        (insert-file-contents-literally filename)
        (if func
            (funcall func))
        (buffer-string)))))

(defun debian-clean-mailname ()
  (while (search-forward "\n" nil t)
    (replace-match "" nil t)))

And that's all gone in 3.0.5. I don't know if emacsen-common-3.0.5 is compatible with our older emacs23-25.

For the mapcar warning in fink-startup.el, v2.0.8 has a change to use dolist().

Updating emacsen-common would probably take care of the warnings, but care needs to be taken to not break emacs23-25. However, the only things that use emacs23-25 are edb and ess, both of which have alternative depends all the way up to emacs26.