Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard WG Meeting - October 24th, 2024 #1400

Open
7 of 18 tasks
kriswest opened this issue Oct 23, 2024 · 10 comments
Open
7 of 18 tasks

Standard WG Meeting - October 24th, 2024 #1400

kriswest opened this issue Oct 23, 2024 · 10 comments

Comments

@kriswest
Copy link
Contributor

kriswest commented Oct 23, 2024

Date

Thursday 24th October 2024 - 10am (US eastern timezone EDT) / 3pm (London, BST)

Zoom info

  • Join Zoom Meeting
  • Meeting ID: 969 4029 4948
  • Passcode: 636931
  • Dial-in:
    Country International Dial-in Toll-free Dial-in
    US +1 929 205 6099 (New York) 877 853 5247
    UK +44 330 088 5830 0800 031 5717
    France +33 1 8699 5831 0 800 940 415
    Find your local number https://zoom.us/u/ad2WVnBzb8

Meeting notices

  • FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

  • All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

  • FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact [email protected] with any questions.

  • FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Participation Requirements

Note: Meeting participants are expected to accept the terms of the FDC3 license (Community Specification License), understand the governance process and have a CLA in place.

Please click the following links at the start of the meeting if you have not done so previously.

Tracking Attendance

Note: Meeting participants are expected to add a comment to this GitHub issue in order that we can track attendance of FDC3 project meetings. Please do this at the start of the meeting.

Agenda

Minutes

  • Proposal of a new FDC3 Editor (Derek Novavi @novavi) and new FDC3 maintainer (Lizaveta Kemereva @kemerava)
    • @kriswest proposed @novavi as an FDC3 Editor and received consent from the meeting to appoint
    • @kriswest proposed @kemerava as an FDC3 maintainer and received consent from the meeting to appoint
  • window.fdc3 should be marked as optional #1385
    • The issue was reviewed and highlighted as an omission from the fdc3-for-web PR, one that was very much intended to be included as a core part of the intended changes - but also as a historical error in earlier FDC3 versions (as it has never been the case that window.fdc3 is always set, or we would not have needed to define an fdc3Ready event (see https://fdc3.finos.org/docs/api/spec#api-access)
      • @kriswest requested and received consent of the meeting to add the PR from @Roaders to the fdc3-for-web branch before it is merged - @Roaders was thanked for pointing out this omission!
      • Some knock-on effects of the change in methods.ts were discussed (e.g. the need for null checks/typeguards)
      • There was additional discussion of the purpose of the functions in methods.ts and whether they should be deprecated (fdc3Ready is superseded by getAgent, enabling es6-style imports of functions is not adding much, it can also be achieved via destructuring with one line of code etc.)
        • There was consensus that these functions should be deprecated in 2.2 and removed in a future major version (FDC3 3.0).
  • Conformance test definitions for FDC3 2.2
    • @kriswest demonstrated where conformance test definitions live in the Standard's repo and asked that PR authors add new test definitions to their PRs where necessary - it was agreed that details on doing so should be added to the proposed PR template.
      • The conformance test definitions do not appear in the Standard's website. However, at least two participating firms have recently been referred to the test definitions to better understand the Standard, hence, it was proposed that they should be accessible through the website in future.
  • @kriswest provided a short review of issues proposed for the FDC3 2.3 scope, how to see the list (see all candidate issues) and asked that participants flag to him or [email protected] or comment directly on any issues that they would like to see discussed at a future meeting.

Action Items

  • @kriswest to propose a Pull request template, to include review criteria for the FDC3 repository, which should include checking that:
    • a CHANGELOG.md entry was included
    • any necessary additions needed to conformance test definitions were made
    • changes applied to docs were also applied to TS files and schemas where necessary
    • code generation functions were run and results added to the PR for any schema changes
    • etc.
  • @robmoffat / FINOS to add @novavi and @kemerava to the fdc3-editors and fdc3-maintainers teams (respectively), the fdc3-maintainers google group, and fdc3-maintainers slack channel etc.
  • @kriswest and other PR authors to add text definitions of conformance test cases to their PRs (https://github.com/finos/FDC3/tree/main/toolbox/fdc3-conformance)
  • @kriswest to raise an issue to deprecate the fdc3Ready function and es6-style functions from methods.ts as superseded by getAgent
  • @bingenito to set up a meeting to walkthrough the fdc3-dotnet 2.1 update PR and facilitate review

Rolled over from previous meetings:

Untracked attendees

Full name Affiliation GitHub username
@paulgoldsmith
Copy link

Paul Goldsmith / Morgan Stanley

@novavi
Copy link

novavi commented Oct 24, 2024

Derek Novavi / S&P Global

@Roaders
Copy link
Contributor

Roaders commented Oct 24, 2024

Giles Roadnight / Morgan Stanley

@kriswest
Copy link
Contributor Author

Kris West / interop.io 🚀

@openfin-johans
Copy link
Contributor

Johan Sandersson / Here™

@robmoffat
Copy link
Member

Rob Moffat / FINOS 🔨

@kemerava
Copy link
Contributor

Lizaveta (Elizabeth) Kemerava / Blackrock

@VedPrakashJha-FMR
Copy link

Ved Jha / Fidelity Investments

@bingenito
Copy link
Member

Brian Ingenito/ Morgan Stanley

@watson-ew
Copy link

Chris Watson / Elgin White 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants