-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Enable management of shades in both AA and AAA #1053
Comments
@lwnoble to add documentation here to tell us what changes in a switch from AA to AAA so that we can identify in code where Keith added this support. |
Talked with @lwnoble today In V1, a design system is either AA or AAA
If I add orange to palette, shades will need to be calculated for AA light and dark and AAA light and dark modes If I select orange-400 as background in AA light, that would cause the corresponding orange-400 to be selected for AAA light and then normal calculations would ensue to determine AA and AAA dark If I select orange-600 as button color in AA light, calculations would need to ensue to select the appropriate color in AA dark and AAA light and dark to ensure text foreground appropriate contrast with the button color
Need to follow up with @lwnoble, but I believe that it would be fine to leave AAA light and dark mode as readonly, like AA dark mode. So that if the user selects the AAA tab, they will be presented with the color values, but not the ability to change them. |
Seems to me that the next steps would be to:
|
Another question for @lwnoble : when we DO support user being able to update AAA light and AA and AAA dark, what does that mean? What should the user experience be? If the user has picked orange-600 for AA light already, would the other 3 also get updated? Or are they all strictly standalone and the user would need to change all 3 to make a sweeping change? |
Problem/Concern
This issue is to investigate, design and code the capability to tell the SDK to update a shade/color and whether that shade or color is a AA or AAA value (e.g. a shade)
Proposed Solution
The text was updated successfully, but these errors were encountered: