Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min and max diagnostics not correct #467

Closed
ta440 opened this issue Dec 6, 2023 · 1 comment
Closed

Min and max diagnostics not correct #467

ta440 opened this issue Dec 6, 2023 · 1 comment

Comments

@ta440
Copy link
Collaborator

ta440 commented Dec 6, 2023

The minimum and maximum diagnostics are defined with absolute values (fabs), so the minimum diagnostic will output the closest value to zero in the domain, not the most negative value. We should make tests for the kernels to ensure they are working correctly.
@tommbendall tommbendall mentioned this issue Mar 12, 2024
Merged
@tommbendall
Copy link
Contributor

Closing as fixed by #488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommbendall @ta440