Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the marker schema, add the ability to mark fields as privacy-sensitive #5301

Open
mstange opened this issue Jan 10, 2025 · 0 comments
Open
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

We currently have two marker field formats called string and sanitized-string.

I think we should remove sanitized-string and allow marking any field, regardless of field format, as privacy-sensitive.

This would avoid the need to add a sanitized-unique-string format; instead you'd be able to just have a unique-string marked with the new field.

Another example of a privacy-sensitive field is the field that stores the screenshot image on CompositorScreenshot markers. CompositorScreenshot markers are currently handled manually during sanitization.

Yet another example are native key events: You might have a marker which carries an integer value with the native key code, which can be used to compute the pressed key. This integer would then be privacy-sensitive, because it would allow you to compute the text that the user typed into a textbox.


Proposal:

type PrivacyCategory = "screenshot" | "url" | "local-path" | "keylogger-ingredient";

type MarkerFieldBase = {
  ...,
  isPrivacySensitiveWithCategory?: PrivacyCategory,
}

The privacy category would determine which checkbox in the upload panel should cause the field to be sanitized away.

┆Issue is synchronized with this Jira Task

@canova canova added profile data Issues related to the profile format, data structure, or profile upgraders markers Anything to do with marker data structures, marker chart, or the marker table labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders
Projects
None yet
Development

No branches or pull requests

2 participants