Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working together with new relic extension #46

Open
nhp opened this issue Oct 25, 2014 · 6 comments
Open

working together with new relic extension #46

nhp opened this issue Oct 25, 2014 · 6 comments

Comments

@nhp
Copy link

nhp commented Oct 25, 2014

If you install firegento_logger together with the proxiblue new relic module http://www.proxiblue.com.au/newrelic-magento-integration.html then logger is stopping its work.

@tkdb
Copy link
Contributor

tkdb commented Oct 28, 2014

Which logger is stopping it's work? That's not clear from your report.

And what happens if you remove the config/global/log entry in proxyblue config.xml?

@datenbrille
Copy link
Contributor

@tkdb this will work. I will put a note in the Readme.md.

@datenbrille
Copy link
Contributor

We should write a NewRelic Logger adapter. @nhp are you in?

@ProxiBlue
Copy link
Contributor

@datenbrille @nhp @tkdb

Edit the config.xml file of the ProxiBlue module.
Find the entry for the log writer.

    <log>
        <core>
            <writer_model>ProxiBlue_NewRelic_Model_Log_Writer_Stream</writer_model>
        </core>
    </log>

and change it to

    <log>
        <core>
            <!-- <writer_model>ProxiBlue_NewRelic_Model_Log_Writer_Stream</writer_model> -->
            <writer_models>
                <newrelic>
                    <label>ProxiBlue NewRelic Logger</label>
                    <class>ProxiBlue_NewRelic_Model_Log_Writer_Stream</class>
                </newrelic>
            </writer_models>
        </core>
    </log>

After this change you will find an entry for the ProxiBlue NewRelic Logger in the Firegento Logger list of available loggers, and you can then control logging to newRelic via the Firegento Logger system

Is there a better way? The main issue would be that both modules set the writer_model, with the NewRelic instance taking precedence (order of loading, I figure)

Any way we can adjust either modules to allow a more seamless integration for the end-user?

@datenbrille
Copy link
Contributor

One solution could be that our Logger depends on yours and we find a way to adapt the config in the code. We thought about that in the last Hackathon but didn't came up for a perfect solution. But we should mention it in the README

@ProxiBlue
Copy link
Contributor

I considered same solution, the other way round, mine to yours.
Not perfect, by far.

What is someone only has yours installed, then the logger class name would
attempt to extend a non-existing class.
Makes the two modules too dependant on each other, I would think.

I have noted the 'fix', as it stands, in my readme

https://github.com/ProxiBlue/NewRelic

On Tue, Feb 17, 2015 at 6:06 AM, Karl Spies [email protected]
wrote:

One solution could be that our Logger depends on yours and we find a way
to adapt the config in the code. We thought about that in the last
Hackathon but didn't came up for a perfect solution. But we should mention
it in the README


Reply to this email directly or view it on GitHub
#46 (comment)
.

[image: proxiblue_document_header.png]

http://www.proxiblue.com.au

Quality, not Quantity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants