Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GompertzStarts #121

Open
droglenc opened this issue Jan 30, 2025 · 2 comments
Open

Adding GompertzStarts #121

droglenc opened this issue Jan 30, 2025 · 2 comments
Assignees

Comments

@droglenc
Copy link
Contributor

Consider adding a function to create reasonable starting values for the Gompertz growth function, in the vein of vbStarts(). When doing this see if some of the code in vbStarts() can be streamline or pulled out to internal functions that could then be used with this new function for Gompertz functions (e.g., plotting; starts for Linf, L0, t0; checking values, etc.).

@droglenc droglenc self-assigned this Jan 30, 2025
@droglenc
Copy link
Contributor Author

I have a functioning prototype that is going to need some testing before use. Some of the starting values for some of the parameterizations are not particularly "close" but could be reasonable enough. The issue seems to be primarily with gettng starting values for L0 and t0, especially if young fish are not present in the data. This is where fixed= will likely be useful.

@droglenc
Copy link
Contributor Author

droglenc commented Feb 4, 2025

I have worked out starting values for Gompertz functions but have move onto doing the same for logistic and Richards functions. In the process I moved to new, more synthetic, functions -- makeGrowthFun(), showGrowthFun(), and findGrowthStarts(). I have made good progress on these, but am now going to be gone for a while. Here are some things to do, so that I remember.

  • Finish putting latex code for the parameterizations in the help file for makeGrowthFun()
  • Consider putting table of where starting values come from in the help file for findGrowthStarts()
  • Remove lifecycle deprecation functions and use .Deprecated from base R (to remove added dependency on lifecycle).
  • Move Schnute-Richards() into makeGrowthFun()
  • Move(?) Schnute() into makeGrowthFun() (more complicated because of the "cases")
  • Put more examples in each documentation
    • makeGrowthFun()
    • findGrowthStarts()
    • showGrowthFun()
  • Develop "sanity tests" (e.g., is Linf positive) in findGrowthStarts() (added one for Linf ... use that as a model)
    • Developed is.lte() and friends, and iChkLTE() and friends ... use these as appropriate ... and develop tests (and consider whether they should be vectorized or not
  • Make testthat tests for the new functions
    • makeGrowthFun()
    • findGrowthStarts()
    • showGrowthFun()
  • Reduce testthat tests for old functions
  • Remove some examples in old functions (to speed checking up)
  • Clean up "Growth_Starting_Values.qmd" article and figure out how to have it appear on webpage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant