Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default AES algorithm should be GCM #39

Open
icidasset opened this issue Mar 29, 2021 · 5 comments
Open

Default AES algorithm should be GCM #39

icidasset opened this issue Mar 29, 2021 · 5 comments

Comments

@icidasset
Copy link
Contributor

Replace current default algorithm AES-CTR with AES-GCM.

@matheus23
Copy link
Member

We could fix this now that #58 landed

@icidasset
Copy link
Contributor Author

👍 And bump version to 1.0?

@matheus23
Copy link
Member

I have some ideas for a "release" 1.0. E.g. I want the store to be abstracted, so that you can use keystore-idb (which at that point will be confusingly named) in nodejs.

Also, I think we can greatly reduce the API surface, because I don't think we're actually using the symmetric key store from keystore-idb anywhere. We're only using the AES helper methods (encryptBytes/decryptBytes).

Not a high priority right now though.

@icidasset
Copy link
Contributor Author

That'd be cool yeah. Where is that symmetric key store? But, it looks like we're using everything that's in aes/*.js.

@matheus23
Copy link
Member

Ah, I'm actually wrong. I was talking about this:
https://github.com/fission-suite/keystore-idb/blob/main/src/keystore/base.ts#L28

But we're actually using the keystore for symmetric keys: We're mainly using exportSymmKey and importSymmKey. My bad :)

Anyway, I still think a good abstraction over localforage in keystore-idb would be great. Probably best to copy the one from webnative into here, and use it from webnative.

If we have that, there's no reason for the dependency injection stuff we have in webnative (keystore-idb would work in nodejs with an appropriate localforage implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants