Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Add persist_pass_through_columns -capability for non-mapping passthrough variables #104

Open
fivetran-catfritz opened this issue Mar 20, 2023 · 0 comments
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Mar 20, 2023

Currently when a non-mapped passthrough/list-style variable is passed to persist_pass_through_columns macro, no error occurs but blank fields are generated. This macro should be updated to handle either list- or dict- style variables. The logic used in fill_pass_through_columns is an example of how this could be done.

This will allow this macro to be brought into older packages, that might not yet use this macro and therefore are expecting list-style, with less friction on the user's end as they will not have to change their variables.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title Add persist_pass_through_columns -capability for non-mapping passthrough variables [FEATURE] - Add persist_pass_through_columns -capability for non-mapping passthrough variables Feb 23, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants