feature(hubspot): Company document (requested by Bonfire for Fivetran AI) #24
+292
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonkorganyan
commented
Feb 18, 2025
| @@ -21,7 +21,7 @@ fields as ( | |||
| select | |||
| {{ | |||
| fivetran_utils.fill_staging_columns( | |||
| source_columns=adapter.get_columns_in_relation(source('rag_hubspot','contact')), | |||
| source_columns=adapter.get_columns_in_relation(source('rag_hubspot','owner')), | |||
There was a problem hiding this comment.
This is an apparent bug fix. Submitted a separate PR for this as well.
levonkorganyan
changed the title
levonkorganyan
changed the title
levonkorganyan
commented
Feb 19, 2025
| @@ -21,15 +21,15 @@ final as ( | |||
| 'hubspot' as platform, | |||
| deal_document.source_relation, | |||
| grouped.most_recent_chunk_update, | |||
| grouped.chunk_index, | |||
| coalesce(grouped.chunk_index, 0) as chunk_index, | |||
There was a problem hiding this comment.
We need this because we're not chunking this object yet, so this is never getting set.
7 tasks
|
@levonkorganyan are the join/coalesce updates to the I have another PR open and was wondering if I should incorporate those changes into it before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for diff purposes only and shouldn't be reviewed for now because it's not up to par for this repo. Fivetran AI is using this branch in its dbt packages instead of the main branch.
Please provide your name and company
Link the issue/feature request which this PR is meant to address
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
How did you validate the changes introduced within this PR?
Which warehouse did you use to develop these changes?
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)