Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Don't run onFinish on hot reload #5

Open
erickzanardo opened this issue May 26, 2020 · 2 comments
Open

Don't run onFinish on hot reload #5

erickzanardo opened this issue May 26, 2020 · 2 comments

Comments

@erickzanardo
Copy link
Member

It seems that the onFinish method is been run again even after the hot reload happens. That makes the development of an app that uses this package very bad. Maybe we could just don't run it after hot reloads.

@luanpotter
Copy link
Member

If you hot reload from start and the screen is shown again we should run it again right? Agreed if it's the keep state hot reload and the screen is not shown, it should not call again. cc @renancaraujo

@erickzanardo
Copy link
Member Author

If you hot reload from start and the screen is shown again we should run it again right? Agreed if it's the keep state hot reload and the screen is not shown, it should not call again. cc @renancaraujo

If you restart, than nothing needs to be done since everything is loaded again, everything will go as expected.

The problem is when you hot reload (pressing r on the terminal).

When doing so, the on finished of the splash screen runs again, and it can a hassle for the development workflow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants