From 0173bdb7b14fbd62cad82c96f9f5e979d6264ced Mon Sep 17 00:00:00 2001
From: user1 <moshe@flanksource.com>
Date: Tue, 17 Oct 2023 18:33:17 +0300
Subject: [PATCH] chore: disable db-metrics by default

---
 cmd/root.go    |  1 +
 pkg/db/init.go | 25 ++++++++++++++-----------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/cmd/root.go b/cmd/root.go
index 08c4b24e7..b2bc0a3d7 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -84,6 +84,7 @@ func init() {
 
 	Root.PersistentFlags().StringVar(&db.ConnectionString, "db", "DB_URL", "Connection string for the postgres database")
 	Root.PersistentFlags().BoolVar(&db.RunMigrations, "db-migrations", false, "Run database migrations")
+	Root.PersistentFlags().BoolVar(&db.DbMetrics, "db-metrics", false, "Expose db metrics")
 	Root.PersistentFlags().BoolVar(&logFail, "log-fail", true, "Log every failing check")
 	Root.PersistentFlags().BoolVar(&logPass, "log-pass", false, "Log every passing check")
 	Root.PersistentFlags().StringArrayVar(&sharedLibrary, "shared-library", []string{}, "Add javascript files to be shared by all javascript templates")
diff --git a/pkg/db/init.go b/pkg/db/init.go
index 0ea2e128e..21accfd3e 100644
--- a/pkg/db/init.go
+++ b/pkg/db/init.go
@@ -22,6 +22,7 @@ var Gorm *gorm.DB
 var ConnectionString string
 var DefaultExpiryDays int
 var RunMigrations bool
+var DbMetrics bool
 var PostgresServer *embeddedpostgres.EmbeddedPostgres
 var HTTPEndpoint = "http://localhost:8080/db"
 
@@ -101,17 +102,19 @@ func Init() error {
 		return err
 	}
 
-	go func() {
-		if err := Gorm.Use(prometheus.New(prometheus.Config{
-			DBName:      Pool.Config().ConnConfig.Database,
-			StartServer: false,
-			MetricsCollector: []prometheus.MetricsCollector{
-				&prometheus.Postgres{},
-			},
-		})); err != nil {
-			logger.Warnf("Failed to register prometheus metrics: %v", err)
-		}
-	}()
+	if DbMetrics {
+		go func() {
+			if err := Gorm.Use(prometheus.New(prometheus.Config{
+				DBName:      Pool.Config().ConnConfig.Database,
+				StartServer: false,
+				MetricsCollector: []prometheus.MetricsCollector{
+					&prometheus.Postgres{},
+				},
+			})); err != nil {
+				logger.Warnf("Failed to register prometheus metrics: %v", err)
+			}
+		}()
+	}
 
 	if RunMigrations {
 		opts := &migrate.MigrateOptions{IgnoreFiles: []string{"007_events.sql", "012_changelog.sql"}}