Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package de.flapdoodle.os #18

Open
yeefan opened this issue Jul 10, 2024 · 3 comments
Open

Split package de.flapdoodle.os #18

yeefan opened this issue Jul 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@yeefan
Copy link

yeefan commented Jul 10, 2024

OS Detection Library depends on OS Detection Library API, and both projects contain a common package de.flapdoodle.os resulting in it being a split package.

This means that OS Detection Library cannot be used in a modular Java application, unless some workaround is applied, e.g., merging OS Detection Library and OS Detection Library API into a fat jar.

@michaelmosmann michaelmosmann self-assigned this Jul 10, 2024
@michaelmosmann michaelmosmann added the enhancement New feature or request label Jul 10, 2024
@michaelmosmann
Copy link
Member

@yeefan so you are using this library for other stuff than tests?

@yeefan
Copy link
Author

yeefan commented Jul 10, 2024

I found this issue when I added unit tests using embed-mongo into an existing project that happened to use the java-modularity Gradle plugin, so by default modularity was also applied to tests. I was able to workaround by turning off modularity for tests.
However, I thought that OS Detection Library is pretty generic, so I opened this issue for your consideration.

@michaelmosmann
Copy link
Member

@yeefan ah.. is see. I will think about that .. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants