New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent waiting for ok to reboot will hammer API server without backoff if API server responds with errors #119

Open

invidian opened this issue Jan 14, 2022 · 1 comment

Labels

bug component/agent

Member

invidian commented Jan 14, 2022

https://github.com/flatcar-linux/flatcar-linux-update-operator/blob/c180704dde101d2c8313c7beabfdfec24fbe8920/pkg/agent/agent.go#L192-L202 this loop should have some kind of backoff on error, as it may fail in the following conditions:

getting Node object fails
creating watcher fails
watching times out (this happens regularly every 24h update agent fails to watch for ok-to-reboot label #23)

invidian added bug component/agent labels

Member Author

invidian commented Feb 10, 2022

Not only this, but once this happens it also won't stop gracefully after closing the control channel.

invidian mentioned this issue

Agent waiting for ok to reboot does not stop gracefully when control channel is closed #129

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment