Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename app #5

Open
nedrichards opened this issue Jun 29, 2018 · 13 comments · May be fixed by #74
Open

Rename app #5

nedrichards opened this issue Jun 29, 2018 · 13 comments · May be fixed by #74

Comments

@nedrichards
Copy link
Member

When we have support for app-id renames we should rename this to net.minetest.minest which is the upstream app-id.

@sofar
Copy link
Collaborator

sofar commented Mar 5, 2019

You mean net.minetest.minetest, right?

@Chirunos
Copy link

Chirunos commented Nov 5, 2023

It seems like this has already been resolved and can be closed

@Calinou
Copy link
Collaborator

Calinou commented Nov 5, 2023

It seems like this has already been resolved and can be closed

This Flatpak currently uses net.minetest.Minetest with an uppercase Minetest. As I understand it, this issue proposes using lowercase minetest instead.

@wjt
Copy link
Member

wjt commented Oct 15, 2024

Great news: Minetest is rebranding to Luanti which will presumably bring a rename to org.luanti.something.

@farribeiro
Copy link
Contributor

And so this issue was solved

@farribeiro
Copy link
Contributor

Hello, good night.

Have you chosen the new appid for the game?

Best regards,
Fábio

@wjt
Copy link
Member

wjt commented Oct 17, 2024

This is not for Flathub to decide: Flathub should follow upstream.

@farribeiro farribeiro linked a pull request Oct 28, 2024 that will close this issue
@farribeiro
Copy link
Contributor

flathub/flathub#5528

@farribeiro
Copy link
Contributor

farribeiro commented Nov 22, 2024

Answering my question... The appid will be org.luanti.Luanti as per luanti-org/luanti#15322

@appgurueu
Copy link
Contributor

Answering my question... The appid will be org.luanti.Luanti as per minetest/minetest#15322

Beware, I hadn't thought about the detail of Luanti casing there. I had just inferred the naming convention based on net.minetest.Minetest. I don't know what's preferred here, but looking at a couple prominent examples most seem to use uppercase app names:

  • org.inkscape.Inkscape
  • org.blender.Blender
  • md.obsidian.Obsidian
  • org.mozilla.Thunderbird

Only counterexample I've found so far: org.mozilla.firefox

So org.luanti.Luanti should be fine.

@albertescanes
Copy link

Hi,

The choice of the case should follow upstream. Old upstream app ID is net.minetest.minetest (with lowercase), just like it was reported here, so I don't know if the uppercsase for Luanti is correct, or it should be org.luanti.luanti.

@wjt
Copy link
Member

wjt commented Nov 24, 2024

The AppStream specification says https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic:

Additionally, even though uppercase letters are permitted in a component-ID, it is strongly encouraged to only use lowercase letters for the ID.

So if someone wants a way to choose between the two, there's that.

@appgurueu
Copy link
Contributor

Thanks for pointing that out. I'll roll with org.luanti.luanti according to the strong encouragement for now then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants