Use stanard React Router over custom useRoute

[jsoules]

I thought I had an issue for this already, but it looks like not, I guess we only discussed in person.

In reviewing PR #65 as part of the discussion around PR #77, I realized how much the useRoute infrastructure will need to grow to support query parsing.

I think we will be much better off moving away from custom routing logic implementation and using stock React Router functionality (both the use-search-params hook, as well as more standard route structuring); & I think this should be a part of the query parameter support PR. I have a model for this in the QUASR Navigator at https://github.com/jsoules/stellarator-navigator/blob/trunk/stellarator-navigator/src/main.tsx and happy to help with it.

[magland]

Sounds good, but before fussing with the implementation, I think it would be helpful to make a design spec for exactly what the url query parameters should look like.

Would it deviate from this?
#65 (comment)

[WardBrian]

I don’t think the URL structure will differ from what we had previously discussed there

[jsoules]

Sounds good, but before fussing with the implementation, I think it would be helpful to make a design spec for exactly what the url query parameters should look like.

Would it deviate from this? #65 (comment)

I agree that that URL structure is fine, though I'd also be happy to allow both sampling_opts and inline_opts with a last-one-wins (or query string beats other source). No need to worry over that right now--should be easy enough to change it later if we want.

[magland]

@WardBrian Why closed? Haven't implemented new router logic yet.

[WardBrian]

Issue #50 seems to cover the re-implementation better