Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation breakpoints don't "fit" for Greek and Russian #298

Open
emersonthis opened this issue Apr 5, 2020 · 0 comments
Open

Navigation breakpoints don't "fit" for Greek and Russian #298

emersonthis opened this issue Apr 5, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@emersonthis
Copy link
Collaborator

Bug:
The breakpoint that determines when the navigation gets hidden behind the hamburger works for English and the romance languages. But the words are longer for Greek and Russian, so there's an awkward overlap on "in between" size screens (tablets, etc)

Screen Shot 2020-04-04 at 5 40 13 PM

Screen Shot 2020-04-04 at 5 41 07 PM

Suggested fix:
The easy (read: lazy) solution would be to just set this $on-tablet breakpoint higher. But this will effect a lot of other styles, so I don't recommend it.

A better solution would be to coordinate with translators to maybe choose shorter words for the nav, if there are acceptable synonyms.

It would also be ideal for the nav to be implemented in a way that's more resilient, and fails more gracefully. The overlapping is the result of absolute positioning, which tends to be problematic and hard to maintain. Maybe we could redo it using flexbox or a different strategy that perhaps results in text wrapping when it doesn't fit (instead of overlapping in an unusable way).

@emersonthis emersonthis added the bug Something isn't working label Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant