Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flet build aab - sign in terminal build bug #4851

Open
1 task done
yoberner opened this issue Feb 7, 2025 · 2 comments
Open
1 task done

flet build aab - sign in terminal build bug #4851

yoberner opened this issue Feb 7, 2025 · 2 comments
Assignees

Comments

@yoberner
Copy link

yoberner commented Feb 7, 2025

Duplicate Check

Describe the bug

flet build aab only correctly signs the .aab file when it is has all of the 4 flags:
flet build aab --android-signing-key-store-password mypassword --android-signing-key-password mypassword --android-signing-key-store keystore.jks --android-signing-key-alias upload_key
This is true even when the project.toml contains:

key_store = "keystore.jks"
key_alias = "upload_key"

Even though the toml has the key_store and key_alias variables, they are still required to put entered into the terminal at the time of running, just the 2 password flags are still not enough.

Operating System

macOS

Operating system details

MacOS 15.2

Flet version

0.26.0

@FeodorFitsner FeodorFitsner self-assigned this Feb 9, 2025
@FeodorFitsner FeodorFitsner added this to the Flet v0.27.0 milestone Feb 10, 2025
@FeodorFitsner
Copy link
Contributor

I'm unable to reproduce the issue.

I'm having the following in pyproject.toml:

[tool.flet.android.signing]
key_store = "keystore.jks"
key_alias = "upload_key"

and I'm running flet build aab -v --android-signing-key-store-password mypassword --android-signing-key-password mypassword and I'm getting the following environment variables passed to flutter build command:

{
   "SERIOUS_PYTHON_SITE_PACKAGES":"/Users/feodor/projects/flet-dev/flet/sdk/python/playground/ext1
/build/site-packages",
   "FLET_ANDROID_SIGNING_KEY_STORE":"keystore.jks",
   "FLET_ANDROID_SIGNING_KEY_STORE_PASSWORD":"mypassword",
   "FLET_ANDROID_SIGNING_KEY_PASSWORD":"mypassword",
   "FLET_ANDROID_SIGNING_KEY_ALIAS":"upload"
}

Looks right?

Please make sure you have settings in pyproject.toml under correct section: [tool.flet.android.signing].

@FeodorFitsner FeodorFitsner removed this from the Flet v0.27.0 milestone Feb 10, 2025
@yoberner
Copy link
Author

Hmm thats weird. Yes my project.toml seems to be set up correctly. But still only works when passed in as a flag as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants