Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-set Simulation.simulation_type based on kwarg to web.run() #1869

Open
tylerflex opened this issue Jul 31, 2024 · 0 comments
Open

Auto-set Simulation.simulation_type based on kwarg to web.run() #1869

tylerflex opened this issue Jul 31, 2024 · 0 comments

Comments

@tylerflex
Copy link
Collaborator

The simulation_type kwarg determines how the simulation gets run on the background.

There's now a field Simulation.simulation_type that adds this flag and is needed for the autograd to differentiate between regular and fwd adjoint tasks for caching purposes.

It would be more robust perhaps if the web.upload() had some logic to either strip this from the Simulation or kwarg, make sure they are consistent, and ultimately place the data in the Simulation.

Would require some backend changes too to use the simulation field, instead of the webapi kwarg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant