Bookmarks order is wrong (again?) / Disabled floccus takes precedence when syncing back

[KalyaSc]

Which version of floccus are you using?

5.3.1

How many bookmarks do you have, roughly?

30

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 128 (64bit)

Which version of Nextcloud Bookmarks are you using? (if relevant)

/

Which version of Nextcloud? (if relevant)

/

What kind of WebDAV server are you using? (if relevant)

Webdav from SFTPGO as docker container.

Describe the Bug

Issue 1: After manual or automatic sync, my bookmarks and folders are appended and not in the correct order. However this does not happened everytime.

Issue 2: If profile's 2 floccus is disabled and I delete all bookmarks and re-enable floccus, profile 2 takes precedence over profile 1 even if sync is manually triggered on profile 1 before profile 2.

Expected Behavior

Issue 1: Folders and bookmarks should have the same order in each browser

Issue 2: Floccus from profile 1 should take precedence over profile 2 (because Floccus was disable on profile 2)

To Reproduce

Sync method: Webdav (docker sftpgo)
Browser: Firefox Version 128.0 (64-bit)
Testing environment: MacOS Sonoma 14.7

2 new Firefox profiles:

• profile 1
• profile 2
• Delete all default bookmarks/folder from both profiles

Floccus installation on both profiles:

• create new floccus profile = floccusDebug
• connect to webdav share with credentials
• create new bookmarks.xbel = floccusDebug.xbel
• bookmarks folder = Bookmarks Toolbar

Floccus sync configuration:

• Auto-sync
• 15 min sync interval
• Always merge local changes with changes from other browsers
• Include this profile's folder in other profiles

Bookmarks/folder annotation:

Folder X.Y
Bookmark X.Y

X = profile 1 or profile 2
Y = nth folder or bookmark

1. Manual sync

---

Issue 1.

• Create a few new dummy folders/bookmarks in profile 1

  • folder 1.1; folder 1.2
  • bookmark 1.1; bookmark 1.2; bookmark 1.3

• Sync floccus now manually on profile 1

• Sync floccus now manually on profile 2

Profile 1

Profile 2

However, If I manually trigger on profile 2 with the synchronization strategy Always undo local changes and download changes from other browsers it gets correctly reordered

Profile 2

Issue 2.

• Disable floccus addon on Firefox profile 2
• Delete all bookmarks and folder on Firefox profile 2
• Enable floccus addons on Firefox profile 2
• Sync floccus now manually on profile 1
• Sync floccus now manually on profile 2
• Sync floccus now mannully on profile 1

Profile 1

Profile 2

However, If I manually trigger on profile 2 with the synchronization strategy Always undo local changes and download changes from other browsers this bug disappears and is not reproducible anymore. Best way to test it is to remove the plugin and reinstall it.

2. Auto sync

---

Synchronization interval = 5min

Same steps as Issues 1. Manual sync except the Floccus auto-sync kicks in.
Exact same results as manual sync.

Same steps as Issue 2. Manual sync except the Floccus auto-sync kicks in.
Exact same results as manual sync.

Debug logs

Debug logs issue 1

Profile 1
floccus-5.3.1-2024-10-22-redacted-issue1-profile1.log

Profile 2
floccus-5.3.1-2024-10-22-redacted-issue1-profile2.log
floccus-5.3.1-2024-10-22-redacted-issue1-profile2-syncmethod.log

Debug logs issue 2

Profile 1
floccus-5.3.1-2024-10-22-redacted-issue2-profile1.log

Profile 2
floccus-5.3.1-2024-10-22-redacted-issue2-profile2.log

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

Thank you for the detailed reproduction steps 💙 I'll try to look into this soon! Sorting issues are a bit lower on my priority list at the moment, though.