Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmarks moved #1767

Open
1 task done
lazymonkey2 opened this issue Nov 13, 2024 · 2 comments
Open
1 task done

bookmarks moved #1767

lazymonkey2 opened this issue Nov 13, 2024 · 2 comments
Labels

Comments

@lazymonkey2
Copy link

Which version of floccus are you using?

5.3.3

How many bookmarks do you have, roughly?

1400

Are you using other means to sync bookmarks in parallel to floccus?

no

Sync method

Google Drive

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

firefox, edge, chrome

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I sync bookmarks between my three browsers (merge).
after a sync I found that some bookmarks are moved from one folder to a different one:

  • in firefox I have 13 bookmarks in a certain folder.
  • in edge the bookmarks are synced correctly
  • in chrome the 13 bookmarks are moved in a different folder
  • the name of the original folder in firefox and the destination (wrong) folder in chrome is the same -> ai (is it relevant?)
  • even after multiple syncs the bookmarks in chrome are not moved to the correct folder
  • to find differences I exported bookmarks from the three browsers in html format, then I removed some useless data in the html files (like timestamps and icons data) and then I compared the html files using winmerge.

Expected Behavior

synced bookmarks correctly

To Reproduce

I don't know. It's just happening when I sync my bookmarks.
I'll attach a screenshot of the difference in html files, and redacted logs.

bug bookmarks moved

floccus-5.3.3-2024-11-13-redacted-firefox.log

floccus-5.3.3-2024-11-13-redacted-edge.log

floccus-5.3.3-2024-11-13-redacted-chrome.log

Debug log provided

  • I have provided a debug log file
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

the name of the original folder in firefox and the destination (wrong) folder in chrome is the same

very interesting, thank you for the detailed description!

I think the name of the folder is relevant. When two folders with the same name are moved to a different location in the same sync run, there is currently no way for the diff algorithm to differentiate them and they may get mixed up, iff the sync runs without any cache available. So, it's a low chance that this happens but there is a chance.

Quick fix would be

  1. Reset cache in the profile settings in all browsers
  2. sync once in all browsers
  3. sort out / remove the duplicates in one browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants