Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PacketType.getLength() says its 4 bytes, but its really 6 #504

Open
rsharo opened this issue Jul 17, 2016 · 1 comment
Open

PacketType.getLength() says its 4 bytes, but its really 6 #504

rsharo opened this issue Jul 17, 2016 · 1 comment

Comments

@rsharo
Copy link

rsharo commented Jul 17, 2016 •
edited
Loading

org.projectfloodlight.openflow.types.PacketType returns 4 from getLength(). It also implements write4Bytes() and read4Bytes() methods, but these methods actually read/write 6 bytes.
@rsharo
Copy link
Author

rsharo commented Jul 17, 2016 •
edited
Loading

Found while working on unit tests for Writeable implementations for OFValueType (PR #505). Leaving this bug alone for now since I don't know who would be impacted downstream if I changed it.

@rsharo rsharo mentioned this issue Jul 17, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsharo