Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Key object pk/id created with api-key and hashed api key #245

Closed
umair313 opened this issue Sep 9, 2023 · 1 comment
Closed

API Key object pk/id created with api-key and hashed api key #245

umair313 opened this issue Sep 9, 2023 · 1 comment
Labels
duplicate A similar issue or PR already exists question Further information is requested

Comments

@umair313
Copy link

umair313 commented Sep 9, 2023

Hey, what is the reason for saving API-key.Hached API-key in as id?
is there some thing specific to security or what?
Thanks
@florimondmanca
Copy link
Owner

Hi @umair313

You can get more context around this issue in #128 and related discussions.

This can be considered a historical design "flaw". I can't exactly remember the reason why I went with this design. My feeling is that we could move to traditional integer PKs without regret. Please feel free to comment and discuss on #128 if you have more ideas on this topic.

Thanks!

@florimondmanca florimondmanca closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@florimondmanca florimondmanca added question Further information is requested duplicate A similar issue or PR already exists labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate A similar issue or PR already exists question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@umair313 @florimondmanca